Stop bundling libraries in release #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
force-pushed
the
static
branch
2 times, most recently
from
49a74ce to
1860aef
Compare
code-asher
approved these changes
Jun 3, 2020
|
You probably already saw the build error, but I'll make note there's a missing |
|
Er, I mean |
|
Mhm yea, pushing rn. |
nhooyr
force-pushed
the
static
branch
3 times, most recently
from
289a35d to
3cd109d
Compare
This way setting --data-dir and --extension-dir in the config file will work for --install--extension and whatnot.
- Instead we now use CentOS 7 for the static build to guarantee that we only depend on libc v2.17 - For macOS we now pull in a static node binary and bundle that instead.
Also confirmed that #1750 is fixed.
Closed
|
Are you planning on making a release with this fix on top of 3.4.0 soon? |
|
Yes 3.4.1 should be out today. |
|
New release is out! https://github.com/cdr/code-server/releases/tag/v3.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we now use CentOS 7 for the static build to guarantee
that we only depend on libc v2.17
For macOS we now pull in a static node binary and bundle that instead.
Updates #1738